DPS909 release 0.3 PR2

Based on previous blog post: here.

My second pull request was a simple fix but a huge bug. It all started when I was working on my previous issue. At school, I downloaded the zip file for SenecaBlackboardExtension from GitHub and ran it on Firefox to see what we have working so far. It had an email login and the "did you know" box was taken out. It was getting near the end of class so I decided to work on the first issue at home. Once I got home I updated my forked repo and test the extension again on Firefox and... it didn't change the page and no errors were displayed. So I quickly went to check the repo to see if any new pull request was merged. There was changes but 1 of the changes was on the readme file and the other change was on the manifest file which was for icons. The change to the readme file shouldn't have affected it so I tried reverting the change in manifest but the extension still didn't change. I then used "blame" from GitHub to show the changes history for the manifest and homepage-guest.js file but there were no changes. So my guess was that it was probably my personal computer that couldn't run it . The next day, at school I downloaded the repo again to test the blackboard extension and it didn't work so at that moment I knew it was not a problem with my computer. I went home and test it on Google Chrome and it gave me this error. Now I know the error is coming from homepage-guest.js file. I thought back to when it worked the first time and I realized homepage-guest.js is now in a "src" directory. The pull request for that fix is here.

Comments

Post a Comment

Popular posts from this blog

My third Hacktoberfest 2018 Journey

This issue I created was suggested by a nice guy(Nate) who already finished 5 PR's. The idea was to increase the performance of a robot program. Instead of using the size method, a global variable would be used to keep track of the remaining robots for a quicker comparison when needed. This program was in C++ which made it very easy for me to read since that is one of my strength. The owner of the repo later told me that he didn't want to use global variables.
Read more

Helping Mozilla firefox with enabling ESLint

Image
It was an amazing experience contributing to Mozilla Firefox. The bug that I worked on: here . For new developers to help with enabling ESLint with FireFox here are the steps that I took ( Window user ) assuming you already have a bug assigned to you: Follow Mozilla Build to download and get the "Required tools" and stop at "Getting the source" Download Mercurial . Continue with Getting the Source and stop at "Build FireFox!" it's not really needed when fixing ESLint bugs and saves some time. Remove your <directory path> from `.eslintignore`. Run `./mach eslint --fix <directory path>` this will run ESLint only for the specific directory you are fixing. Note: I was told to commit 2 versions: An automatic change version and a manual change version.      6.  So at this point I did `hg commit -m "Enable ESLint for <directory path> (automatic changes)"` Since I was told I needed 2 commits I wanted to push my
Read more

Contributing to 2048 Repo cont'd

GitHub Repo: 2048 Previously, when I was working on this repository it turns out my code format was not consistent with what they had. I've noticed that they have a .clang-format file which means there should be a way for me to run it and auto format my code. After searching, I have found a couple of online formatters. When I used the online formatters it either spits back the same code format or it loads until timeout, either way I don't get what I am trying to do. I went back to searching for clang-formats and I came across a Visual Studio Code extension that allows me to use the .clang-format file. After running the clang-format on the source files, compiling errors start to arise from the .clang-format file which I have posted an issue on. After trying to fix a few of the errors the owner of the repo believes the error could be related to the VSCode extension. Apparently, they were using npm to run the clang-format file. Maybe I should have asked how they did the forma
Read more