Helping Mozilla firefox with enabling ESLint

It was an amazing experience contributing to Mozilla Firefox.
The bug that I worked on: here.
For new developers to help with enabling ESLint with FireFox here are the steps that I took (Window user) assuming you already have a bug assigned to you:
  1. Follow Mozilla Build to download and get the "Required tools" and stop at "Getting the source"
  2. Download Mercurial.
  3. Continue with Getting the Source and stop at "Build FireFox!" it's not really needed when fixing ESLint bugs and saves some time.
  4. Remove your <directory path> from `.eslintignore`.
  5. Run `./mach eslint --fix <directory path>` this will run ESLint only for the specific directory you are fixing.
Note: I was told to commit 2 versions: An automatic change version and a manual change version.
     6.  So at this point I did `hg commit -m "Enable ESLint for <directory path> (automatic changes)"`

Since I was told I needed 2 commits I wanted to push my automatic changes before doing the manual changes so I tried hg push and I got an error apparently we should be using moz-phab to push changes.

     7. Some more setup. Download moz-phab zip. You will also need arcanist.
Note: Another part that I got stuck on was in arcanist, for step 3 it says "Copy php.ini-development to php.ini in that same directory" this just mean rename the "php.ini-development" file to "php.ini"
     
     8. Before you get into "Configuring arcanist" step 12 of arcanist. Test arc command by typing `arc help` in prompt to see if arc is in your environment.

Note: You will need "arc" and "moz-phab" and "PHP" in your system environment variable.
Note: After you copy the bin path in your computer environment variable you will need to restart your computer for it to work.

Luckily for me, Julia told me when I do moz-phab submit it will push all my commits at once.

    9. At this point just put the arcanist and moz-phab on hold and start fixing the ESLint errors. You will thank me for this.

   10. Once you finish fixing ESLint errors with ./mach eslint <directory path>. Do another commit for manual changes: `hg commit -m "Enable ESLint for <directory path> (manual changes)"`
   
   11. Now you can get back to Configuring arcanist. You will need an authenticator connected to Bugzilla.

  12. Lastly run: python <Your path/moz-phab>. This will ask if you want to submit and if you type "yes" it will automatically push for you.

This is the final result I got at the end: 


Special thanks to David for connecting me to other members that were working on this, and Mark Banner, Julia, Shreena and Adam for helping me with ESLint errors.

Comments

Post a Comment

Popular posts from this blog

DPS909 release 0.3 PR2

Based on previous blog post: here . My second pull request was a simple fix but a huge bug. It all started when I was working on my previous issue . At school, I downloaded the zip file for SenecaBlackboardExtension from GitHub and ran it on Firefox to see what we have working so far. It had an email login and the "did you know" box was taken out. It was getting near the end of class so I decided to work on the first issue at home. Once I got home I updated my forked repo and test the extension again on Firefox and... it didn't change the page and no errors were displayed. So I quickly went to check the repo to see if any new pull request was merged. There was changes but 1 of the changes was on the readme file and the other change was on the manifest file which was for icons. The change to the readme file shouldn't have affected it so I tried reverting the change in manifest but the extension still didn't change. I then used "blame" from GitHub to s...
Read more

DPS909 release 0.3

For my open source class at Seneca, we are now at a phase where we can start creating our own open source project. After both class have brainstormed brilliant ideas, 12 of the most popular ones are created. From the 12 projects, I was interested in two of them. The first one was the SenecaBlackboardExtension project because as a user I know best what could be improved. The other project that interest me was the Turn-based creative writing web app . The first issue that I created on SenecaBlackboardExtension was a great idea suggested by my professor(David Humphrey), which was to include a details/summary block to show/hide things on the site, instead of removing everything from the website. The first place I thought of using this was the Seneca Services box, since all the links in the box are important but only a couple are used most often, so I decided to add a collapsible view for the links that aren't used as often in the issue I've created.
Read more

My hacktoberfest 2018 journey reflection

During the Hacktoberfest month I have worked on these issues: https://github.com/theelous3/asks/issues/87 https://github.com/notepad-plus-plus/notepad-plus-plus/issues/4907 https://github.com/filerjs/filer/issues/551 https://github.com/cjlcarvalho/crazy-robots/issues/18 https://github.com/cjlcarvalho/crazy-robots/issues/20 https://github.com/cjlcarvalho/crazy-robots/issues/2 What I have learnt:       I have realized that 5 pull requests may not seem like a big number to do but to do that in a one month of time, it's more than you'd think. At first I completed an issue during the first week so things were going as planned. During the first week, I also got to learn a new programming language(Python) mostly just to understand the part that I was working on. Once I got to the second issue, I got stuck at setting up the environment, it took about 1-2 weeks and I was still getting errors while trying to build the code. That is when I decided I should push this is...
Read more